From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_resetwal prints new OldestXID in wrong circumstances
Date: Wed, 19 Nov 2025 18:08:22 +0200
Message-ID: <638e63ba-b8a3-4236-9c48-0d4a5ef2f034@iki.fi> (raw)
In-Reply-To: <aR2WWN6fW/8BFOkx@ip-10-97-1-34.eu-west-3.compute.internal>
References: <5461bc85-e684-4531-b4d2-d2e57ad18cba@iki.fi>
<aR2WWN6fW/8BFOkx@ip-10-97-1-34.eu-west-3.compute.internal>
On 19/11/2025 12:05, Bertrand Drouvot wrote:
> On Wed, Nov 19, 2025 at 11:52:31AM +0200, Heikki Linnakangas wrote:
>> Printing the new OldestXID value is incorrectly tied to whether the
>> --next-transaction-id option is given, so this prints it, even though
>> OldestXID is not being modified:
>
> Nice catch!
>
>> This seems to have been an oversight when the --oldest-transaction-id option
>> was added (commit 74cf7d46a91d).
>
> yeah.
>
>> Before that, OldestXID was reset when the
>> --next-transaction-id option was given.
>>
>> Fix attached. Barring objections, I will commit and backpatch this.
>
> LGTM, thanks!
Committed, thanks!
- Heikki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: hlinnaka@iki.fi, bertranddrouvot.pg@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_resetwal prints new OldestXID in wrong circumstances
In-Reply-To: <638e63ba-b8a3-4236-9c48-0d4a5ef2f034@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox