pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: Tristan Partin <tristan@neon.tech>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: gdo@leader.it
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
Date: Sat, 10 Jun 2023 14:42:54 -0400
Message-ID: <665279.1686422574@sss.pgh.pa.us> (raw)
In-Reply-To: <f1856a5d-3703-66ff-e7c7-01d2489315c1@joeconway.com>
References: <17946-3e84cb577e9551c3@postgresql.org>
	<1564676.1685043220@sss.pgh.pa.us>
	<555bb26e-c27c-ab65-028f-3fd5b82df9de@iki.fi>
	<CT887GSPI31W.BQCSW35JL67L@gonk>
	<ca35e375-be82-322d-8c81-78127d8fb33f@joeconway.com>
	<5676b739-0854-f924-4b97-466e3504c692@joeconway.com>
	<f1856a5d-3703-66ff-e7c7-01d2489315c1@joeconway.com>

Joe Conway <mail@joeconway.com> writes:
> 5/ The attached fixes the issue for me on pg10 and passes check-world.
> Comments?

The call in PGLC_localeconv seems *very* oddly placed.  Why not
do that before it does any other locale calls?  Otherwise you don't
really have reason to believe you're saving the appropriate
values to restore later.

			regards, tom lane





view thread (38+ messages)  latest in thread

Message-ID: <665279.1686422574@sss.pgh.pa.us>
Permalink:  ../665279.1686422574@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/665279.1686422574@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mail@joeconway.com, tristan@neon.tech, hlinnaka@iki.fi, gdo@leader.it, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
  In-Reply-To: <665279.1686422574@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox