pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: Mon, 21 Jul 2014 13:17:25 -0400
Message-ID: <6720.1405963045@sss.pgh.pa.us> (raw)
In-Reply-To: <20140721170953.GP5974@alap3.anarazel.de>
References: <19458.1405899435@sss.pgh.pa.us>
	<20140720234925.GJ5974@alap3.anarazel.de>
	<22178.1405903964@sss.pgh.pa.us>
	<26504.1405912770@sss.pgh.pa.us>
	<20140721161222.GA17049@alap3.anarazel.de>
	<3655.1405959656@sss.pgh.pa.us>
	<20140721163409.GB14989@alap3.anarazel.de>
	<4182.1405961004@sss.pgh.pa.us>
	<20140721164857.GO5974@alap3.anarazel.de>
	<6333.1405962201@sss.pgh.pa.us>
	<20140721170953.GP5974@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-07-21 13:03:21 -0400, Tom Lane wrote:
>> I don't see any point in being picky about it.  What we want is to reject
>> values that are conclusively bogus; things that are just close to bogus
>> are not so interesting.

> It'd just have been about optimizing away repeated calls to ReadNew*...

Oh.  I think the existing code is probably efficient enough about that.
vac_update_datfrozenxid() only does it once anyway, and the calls in
vac_update_relstats() are arranged so that we don't expect them to be hit
at all in normal cases.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (78+ messages)  latest in thread

Message-ID: <6720.1405963045@sss.pgh.pa.us>
Permalink:  ../6720.1405963045@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6720.1405963045@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com
  Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
  In-Reply-To: <6720.1405963045@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox