From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
Date: Fri, 3 Jan 2020 08:54:35 +0100
Message-ID: <6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com> (raw)
In-Reply-To: <1628.1572820800@sss.pgh.pa.us>
References: <16059-8836946734c02b84@postgresql.org>
<30313.1572729260@sss.pgh.pa.us>
<1628.1572820800@sss.pgh.pa.us>
On 2019-11-03 23:40, Tom Lane wrote:
> * The patch now always quotes completed filenames, so quote_if_needed()
> is misnamed and overcomplicated for this use-case. I left the extra
> generality in place for possible future use. On the other hand, this
> is the*only* use-case, so you could also argue that we should just
> simplify the function's API. I have no strong opinion about that.
I haven't found an explanation in this thread why it does always quote
now. That seems a bit unusual. Is there a reason for this? Can we do
without it?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
In-Reply-To: <6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox