From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nagaraj Raj <nagaraj.sf@yahoo.com>
Cc: Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition
Date: Tue, 29 Sep 2020 19:21:30 -0400
Message-ID: <727064.1601421690@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
References: <20200929223907.GA14950@alvherre.pgsql>
<725317.1601419418@sss.pgh.pa.us>
<CAApHDvrtVBHpFCSRP_KbYptX4LRv3LXthRPJQhfPKHouXvwauA@mail.gmail.com>
<CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
David Rowley <dgrowleyml@gmail.com> writes:
> On Wed, 30 Sep 2020 at 12:08, David Rowley <dgrowleyml@gmail.com> wrote:
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> "Unique constraints (and[, by extension,] primary key constraints) on
>>> partitioned tables must include all the partition key columns.
> I didn't go with the same wording. The reason was that I didn't feel
> the word "constraint" had to be mentioned twice.
> I won't object if you or Alvaro want to keep Alvaro's suggestion though.
I kind of like Alvaro's wording because it helps to reinforce the point
that pkeys are a type of unique constraint. If you dislike repeating
"constraints", perhaps we could go with something like
Unique constraints (and hence primary keys) on partitioned tables ...
I'm not hugely against your wording though.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, alvherre@2ndquadrant.com, nagaraj.sf@yahoo.com
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition
In-Reply-To: <727064.1601421690@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox