From: Tom Lane <tgl@sss.pgh.pa.us>
To: Staroverov Ilja <i.staroverov@ftdata.ru>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Query jumbling ignores XML names, ROLLUP/CUBE, VARIADIC and more
Date: Mon, 26 Oct 2026 14:26:34 -0400
Message-ID: <737423.1793039194@sss.pgh.pa.us> (raw)
In-Reply-To: <B388C5B3-83C2-44B3-B883-BE72A9E5A2B5@localhost.localdomain>
References: <B388C5B3-83C2-44B3-B883-BE72A9E5A2B5@localhost.localdomain>
Staroverov Ilja <i.staroverov@ftdata.ru> writes:
> While working on the SQL/JSON patterns in pg_stat_statements [1], I
> looked at the other fields marked query_jumble_ignore, and some of them
> change the results of the queries.
I don't believe that query jumbles have ever been intended to
distinguish every semantic detail of a query tree. To the contrary,
merging together "sufficiently similar" queries has always been
precisely the intention. So there is not one of these things that
deserves the label of bug. We can have a discussion about whether
the original (and clearly intentional) choice to mark a field as
query_jumble_ignore was being too aggressive about what is "similar",
but in each case that's going to be a judgment call.
So rather than submitting a patch and expecting it to get pushed,
you need to try to create some consensus on the -hackers list about
whether these things should be changed. To my mind the benefit of
the doubt should probably go to the existing behaviors.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, i.staroverov@ftdata.ru, michael@paquier.xyz
Subject: Re: Query jumbling ignores XML names, ROLLUP/CUBE, VARIADIC and more
In-Reply-To: <737423.1793039194@sss.pgh.pa.us>
References: <B388C5B3-83C2-44B3-B883-BE72A9E5A2B5@localhost.localdomain> <737423.1793039194@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox