From: Tom Lane <tgl@sss.pgh.pa.us>
To: wzssyqa@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: Thu, 13 Jun 2019 10:07:15 -0400
Message-ID: <7749.1560434835@sss.pgh.pa.us> (raw)
In-Reply-To: <15844-8f62fe7e163939b3@postgresql.org>
References: <15844-8f62fe7e163939b3@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> MIPS r6 changes the encoding of LL/SC instruction,
> while the .set mips2 will force assembler to generate
> old encoding.
> This patch can fix this problem.
So I have a bunch of questions about this patch.
1. What problem is this actually solving? We have what I think are
reasonably modern MIPS machines in the buildfarm (frogfish,
topminnow) and they aren't complaining.
2. What toolchains define __mips_isa_rev at all? Seems like we could
be trading one portability issue for another one.
3. If we actually need something here, don't we need a run-time probe
rather than a compile-time check? Distro packagers, for example,
can't assume that their packages will be run on exactly the hardware
they build on.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, wzssyqa@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
In-Reply-To: <7749.1560434835@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox