pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: YunQiang Su <wzssyqa@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: Sat, 22 Jun 2019 19:21:40 -0400
Message-ID: <29166.1561245700@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKcpw6UtS-y7ZRBm+9FAsL8NXeBhhBpqdK47ifYbYFvoq2g7cg@mail.gmail.com>
References: <15844-8f62fe7e163939b3@postgresql.org>
	<15052.1560455595@sss.pgh.pa.us>
	<CAKcpw6W2WBdTVnJSeV845V78bwOPDjhROfteX7D2o0TTU2_opA@mail.gmail.com>
	<23287.1560655935@sss.pgh.pa.us>
	<CAKcpw6W8Y56cxKJna6EsA+j2ZQ1p6DeXwMJFOOjb=baPigbV+Q@mail.gmail.com>
	<25321.1560659282@sss.pgh.pa.us>
	<CAKcpw6XYkD9Ku-0Fw6VZ6=wR030c5xCBOnTGsjLzFqdffkM8dw@mail.gmail.com>
	<22615.1560701813@sss.pgh.pa.us>
	<20190617163207.kgi5m4v2g2m252t5@alap3.anarazel.de>
	<8749.1560790222@sss.pgh.pa.us>
	<CAKcpw6VZVerXTHWSxp341GeogHQBOY9p5w3VRwGMXcxcr_hhtw@mail.gmail.com>
	<19682.1561230332@sss.pgh.pa.us>
	<27494.1561243027@sss.pgh.pa.us>
	<CAKcpw6UtS-y7ZRBm+9FAsL8NXeBhhBpqdK47ifYbYFvoq2g7cg@mail.gmail.com>

YunQiang Su <wzssyqa@gmail.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> 于2019年6月23日周日 上午6:37写道：
>> So I now think your original proposal was about the best way to do this,
>> though I'd tweak it to make the test be "#if __mips_isa_rev < 2", as

> here we should use #if __mips < 2 instead of __mips_isa_rev .

OK, will do.

			regards, tom lane





view thread (20+ messages)

Message-ID: <29166.1561245700@sss.pgh.pa.us>
Permalink:  ../29166.1561245700@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29166.1561245700@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, wzssyqa@gmail.com, andres@anarazel.de, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
  In-Reply-To: <29166.1561245700@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox