pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16780: Inconsistent recovery_target_xid handling across platforms
Date: Wed, 23 Dec 2020 09:00:00 +0300
Message-ID: <7e691f38-666e-7991-1107-f87608575560@gmail.com> (raw)
In-Reply-To: <X+LLO1qy1f8ak96J@paquier.xyz>
References: <16780-107fd0c0385b1035@postgresql.org>
	<X+BLDQOGr4V5oeBz@paquier.xyz>
	<X+F99vxLRK8MXAni@paquier.xyz>
	<X+LLO1qy1f8ak96J@paquier.xyz>

23.12.2020 07:44, Michael Paquier wrote:
> On Tue, Dec 22, 2020 at 02:02:46PM +0900, Michael Paquier wrote:
>> So, attached is a patch to make the logic more consistent that I would
>> like to apply down to 12.  Please let me know if there are any
>> objections or comments.
> I have looked at that again this morning, and applied a fix down to
> 9.6 with the change in the TAP tests based on pg_resetwal.  In 9.5,
> pg_strtouint64() is not available, but this branch is old enough that
> it did not seem worth the extra effort.
Thank you!
I think that with this change, if the check for epoch will be added
someday, it will work consistently too.

Best regards,
Alexander





view thread (6+ messages)  latest in thread

Message-ID: <7e691f38-666e-7991-1107-f87608575560@gmail.com>
Permalink:  ../7e691f38-666e-7991-1107-f87608575560@gmail.com/
Also on:    postgresql.org/message-id/7e691f38-666e-7991-1107-f87608575560@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16780: Inconsistent recovery_target_xid handling across platforms
  In-Reply-To: <7e691f38-666e-7991-1107-f87608575560@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox