public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Virender Singla <[email protected]>
Cc: [email protected]
Cc: Aniket Jha <[email protected]>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
Date: Mon, 02 Mar 2026 11:17:03 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZmWg9FfHBLxw7vCJ7pkdWJtW6AMCUvoARTVYqcmeAW=w@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CA+TgmoauoiW4ydDhdrseg+DD4Kwha=+TSZp18BrJeHKx3o1Fdw@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYFc1x11Y7AHxn6Jb0mvJ9-aPttmjqezj=YKnHmqVb-Wg@mail.gmail.com>
	<[email protected]>
	<CA+TgmobNKFc34nj+w6iX0zWJ1=mfYWqQS91PqsJrm4VD4o1yOw@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYJ8Y1G1r9U7pRwnyw=8dmM0xygLguE+bdihkN8GwPuCQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmobZRL02-R7k_i3ENYz8CmqCPUZv6cHY51BejqPy7OhFJw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+TgmobMUVTj=5csi-vT=w731H5PBj+0SpCS_AndZEv_eum-jA@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZmWg9FfHBLxw7vCJ7pkdWJtW6AMCUvoARTVYqcmeAW=w@mail.gmail.com>

Robert Haas <[email protected]> writes:
> On Fri, Feb 27, 2026 at 4:52 PM Tom Lane <[email protected]> wrote:
>> Fair ... do you have a suggestion for less confusing names?
>> I considered naming the new variable "dump_this_grantor", but thought
>> it was longer without being more helpful ... but maybe you disagree.

> Personally, I'd find the extra verbosity helpful, but I don't care
> that much if you see it otherwise.

If you think that's better, I'm happy to make it so.  An author is
seldom the best judge of readability of his code.

Pushed like that.

			regards, tom lane

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox