pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Hamid Akhtar <hamid.akhtar@gmail.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Bug in error reporting for multi-line JSON
Date: Mon, 01 Mar 2021 16:50:01 -0500
Message-ID: <849057.1614635401@sss.pgh.pa.us> (raw)
In-Reply-To: <01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se>
References: <CANbhV-EPBnXm3MF_TTWBwwqgn1a1Ghmep9VHfqmNBQ8BT0f+_g@mail.gmail.com>
	<914794.1611252508@sss.pgh.pa.us>
	<CANbhV-FJk_+XTcnuuxujP2FUi7qwC=sUUyEBcbqYoOWmZhxD4A@mail.gmail.com>
	<CANugjhuR8U+uzSptTZ7tEUGvCt8vGnSz89rRw+89yd+wx_nLvA@mail.gmail.com>
	<CANugjhsOvEk9OJ4b1Y3CxC9A8GwHt-cRU1-ymiod859En833-Q@mail.gmail.com>
	<01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> I'm changing the status of this patch to Ready for Committer.

I reviewed this and pushed it, with some changes.

I noted that there was a basically unused "line_start" field in
JsonLexContext, which seems clearly to have been meant to track
what the new field was going to track.  So we can fix this without
any new field by updating that at the right times.

I thought putting jsonb tests into json.sql was a bit poorly
thought out.  I ended up adding parallel tests to both json.sql
and jsonb.sql ... maybe that's overkill, but a lot of the rest
of those scripts is duplicative too.  The tests weren't exercising
the dots-at-start-of-line behavior, either.

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <849057.1614635401@sss.pgh.pa.us>
Permalink:  ../849057.1614635401@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/849057.1614635401@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, hamid.akhtar@gmail.com, simon.riggs@enterprisedb.com
  Subject: Re: Bug in error reporting for multi-line JSON
  In-Reply-To: <849057.1614635401@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox