pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: YunQiang Su <wzssyqa@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: Mon, 17 Jun 2019 12:50:22 -0400
Message-ID: <8749.1560790222@sss.pgh.pa.us> (raw)
In-Reply-To: <20190617163207.kgi5m4v2g2m252t5@alap3.anarazel.de>
References: <15844-8f62fe7e163939b3@postgresql.org>
	<15052.1560455595@sss.pgh.pa.us>
	<CAKcpw6W2WBdTVnJSeV845V78bwOPDjhROfteX7D2o0TTU2_opA@mail.gmail.com>
	<23287.1560655935@sss.pgh.pa.us>
	<CAKcpw6W8Y56cxKJna6EsA+j2ZQ1p6DeXwMJFOOjb=baPigbV+Q@mail.gmail.com>
	<25321.1560659282@sss.pgh.pa.us>
	<CAKcpw6XYkD9Ku-0Fw6VZ6=wR030c5xCBOnTGsjLzFqdffkM8dw@mail.gmail.com>
	<22615.1560701813@sss.pgh.pa.us>
	<20190617163207.kgi5m4v2g2m252t5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I think we're pretty much at the point where we should just rip out all
> of our own spinlock implementations for non-common platforms, and solely
> rely on compiler intrinsics... The open coded ASM really doesn't age
> very well, and there's very little chance of us actually testing them
> properly.

It's completely not true that this code isn't tested; we have two
different MIPS buildfarm machines that surely exercise spinlocks plenty.

(There's a separate argument to be had about whether we should drop
source-code support for platforms that aren't represented in the
buildfarm.  I'm not inclined to, but you could tenably hold that
position.)

As for compiler intrinsics, I dunno.  I don't have very much faith in
the quality of those for non-mainstream platforms, either --- see
https://www.postgresql.org/message-id/flat/25414.1483076673%40sss.pgh.pa.us
for a not-too-old example.  And a lot of platforms like this are running
pretty old compilers, so even if the problems have been fixed it'll be a
long time before we can depend on that.

			regards, tom lane





view thread (20+ messages)  latest in thread

Message-ID: <8749.1560790222@sss.pgh.pa.us>
Permalink:  ../8749.1560790222@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8749.1560790222@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, wzssyqa@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
  In-Reply-To: <8749.1560790222@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox