From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: cameron.ezell@clearcapital.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns
Date: Fri, 17 Apr 2020 11:04:46 +0200
Message-ID: <8e6df41a-d0a3-681f-1ac3-b0e2227103cc@2ndquadrant.com> (raw)
In-Reply-To: <20200416053036.GA81957@paquier.xyz>
References: <16369-5845a6f1bef59884@postgresql.org>
<CAApHDvr7xeMcfGRWQ0rxtagw7CKbjEcjPKfKQAU4KdEcZm6XkQ@mail.gmail.com>
<1047.1586994741@sss.pgh.pa.us>
<CAApHDvqFZZOwCi35xi02G=19df7idzminAhibrHEAz4McEnX=w@mail.gmail.com>
<20200416053036.GA81957@paquier.xyz>
On 2020-04-16 07:30, Michael Paquier wrote:
> On Thu, Apr 16, 2020 at 12:40:24PM +1200, David Rowley wrote:
>> On Thu, 16 Apr 2020 at 11:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> That looks like it'll fail on a null result.
>>
>> Thanks. I'll have another go then.
>
> Shouldn't you have more regression test cases here? I guess one for
> the non-NULL case, and one for the NULL case?
I've tried creating a smaller test case, but it's difficult. I haven't
fully understood the reason why it sometimes crashes and sometimes not.
The smallest I could come up with so far is something like this:
CREATE TABLE crash (
hostname varchar,
hostname_short varchar GENERATED ALWAYS AS (hostname) STORED,
device text,
mount text,
used_space_bytes bigint,
avail_space_bytes bigint
);
INSERT INTO crash (hostname, device, mount, used_space_bytes,
avail_space_bytes) VALUES (repeat('1234567890', 100), 'devtmpfs',
'/dev', 0, 6047076131313);
Would this be easier to reproduce with one of the memory-cleaning
#defines enabled?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, cameron.ezell@clearcapital.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns
In-Reply-To: <8e6df41a-d0a3-681f-1ac3-b0e2227103cc@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox