pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jan Nidzwetzki <jan@planetscale.com>
To: Fujii Masao <masao.fujii@gmail.com>
To: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: ♂π≌26218 <1991230470@qq.com>
Cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: START_REPLICATION silently truncates an overlong LSN component
Date: Wed, 28 Oct 2026 12:33:35 +0100
Message-ID: <8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com> (raw)
In-Reply-To: <CAHGQGwFc7g1W+2GZj6z1UT61Yugg7WGxhgNpkbqDcA8d0p3pkg@mail.gmail.com>
References: <tencent_C6ED19DF1759CDD37E786F7EE0B5207D0009@qq.com>
	<OS7PR01MB18317EED85B1A72C69B226630F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwF1VdMww-2s4To3W14Gw48-=4=aUWDyw-ER5WTVm0RTBA@mail.gmail.com>
	<OS7PR01MB183171391E7DA9DB9DBDEF419F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwFJs1Kb3kqpatk-=d2M5g=7yar+dyrDiqNYYVFf-F3-rQ@mail.gmail.com>
	<OS7PR01MB1831746179FE303840ABEDBD4F5662@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwEcR5vUL7CFrYSSKAW9Cba9o-b=EsoNjqCU_6iuz+rwTA@mail.gmail.com>
	<OS7PR01MB1831703F6C7FD5F783A0B7F6EF5642@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwF97J+RLnz1gewoM6Sh2XbsEHAm=ytgeUPqD8xoTB6xXQ@mail.gmail.com>
	<OS7PR01MB18317955E3D7441FB5BEDC77FF5612@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com>
	<OS7PR01MB18317807F36995E27C57C915AF56F2@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwFc7g1W+2GZj6z1UT61Yugg7WGxhgNpkbqDcA8d0p3pkg@mail.gmail.com>

Hi Kuroda-san, Fujii-san,

On 28.10.26 11:50, Fujii Masao wrote:
> On Wed, Oct 28, 2026 at 12:18 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
>> Hmm. But 5ffb8c74 also did not have any tests and the error "syntax error in history file:"
>> is nor verified, right? I still feel we can follow the manner.
> 
> I'm not convinced that 0002 and 0003 are necessary. OTOH, there seems to be
> general agreement on 0001, so barring any objections, I'll commit that patch.

No objections from my side.

Kuroda-san, you are right about CppAsString2(). I missed that the value
is stringified for scanf. Thanks for checking. So, I am fine with 0001.
The static assert and the test can be left out.

Best regards
   Jan

-- 
Jan Nidzwetzki
PlanetScale Postgres Core Team







view thread (20+ messages)  latest in thread

Message-ID: <8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com>
Permalink:  ../8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com/
Also on:    postgresql.org/message-id/8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: jan@planetscale.com, masao.fujii@gmail.com, kuroda.hayato@fujitsu.com, ayushtiwari.slg01@gmail.com, 1991230470@qq.com
  Subject: Re: START_REPLICATION silently truncates an overlong LSN component
  In-Reply-To: <8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com>
  References: <tencent_C6ED19DF1759CDD37E786F7EE0B5207D0009@qq.com> <CAHGQGwF1VdMww-2s4To3W14Gw48-=4=aUWDyw-ER5WTVm0RTBA@mail.gmail.com> <OS7PR01MB183171391E7DA9DB9DBDEF419F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwFJs1Kb3kqpatk-=d2M5g=7yar+dyrDiqNYYVFf-F3-rQ@mail.gmail.com> <OS7PR01MB1831746179FE303840ABEDBD4F5662@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwEcR5vUL7CFrYSSKAW9Cba9o-b=EsoNjqCU_6iuz+rwTA@mail.gmail.com> <OS7PR01MB1831703F6C7FD5F783A0B7F6EF5642@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwF97J+RLnz1gewoM6Sh2XbsEHAm=ytgeUPqD8xoTB6xXQ@mail.gmail.com> <OS7PR01MB18317955E3D7441FB5BEDC77FF5612@OS7PR01MB18317.jpnprd01.prod.outlook.com> <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com> <OS7PR01MB18317807F36995E27C57C915AF56F2@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwFc7g1W+2GZj6z1UT61Yugg7WGxhgNpkbqDcA8d0p3pkg@mail.gmail.com> <8f98c2af-ca6d-4cc5-9c88-5cb1505a3db7@planetscale.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox