pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Daniel Gustafsson <daniel@yesql.se>
To: jal@etc.to, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: BUG #16683: explain plan format xml produces invalid xml
Date: Fri, 23 Oct 2020 13:12:13 +0200
Message-ID: <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se> (raw)
In-Reply-To: <16683-8005033324ad34e9@postgresql.org>
References: <16683-8005033324ad34e9@postgresql.org>

> On 23 Oct 2020, at 12:26, PG Bug reporting form <noreply@postgresql.org> wrote:

> Sort-Space is incorrectly finished with /Sort-Spaces

Nice catch, it was introduced in the Incremental Sort patch, both for disk and
memory type sorts as per the attached (unless the opening of the group was
supposed to be "Sort Spaces" but singular seems the right choice here). 

cheers ./daniel

Attachments:

explain_sort_space.diff (application/octet-stream, 968B) download
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index 41317f1837..43f9b01e83 100644
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -2827,7 +2827,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
 			ExplainPropertyInteger("Peak Sort Space Used", "kB",
 								   groupInfo->maxMemorySpaceUsed, es);
 
-			ExplainCloseGroup("Sort Spaces", memoryName.data, true, es);
+			ExplainCloseGroup("Sort Space", memoryName.data, true, es);
 		}
 		if (groupInfo->maxDiskSpaceUsed > 0)
 		{
@@ -2844,7 +2844,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
 			ExplainPropertyInteger("Peak Sort Space Used", "kB",
 								   groupInfo->maxDiskSpaceUsed, es);
 
-			ExplainCloseGroup("Sort Spaces", diskName.data, true, es);
+			ExplainCloseGroup("Sort Space", diskName.data, true, es);
 		}
 
 		ExplainCloseGroup("Incremental Sort Groups", groupName.data, true, es);

view thread (4+ messages)  latest in thread

Message-ID: <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se>
Permalink:  ../90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se/
Also on:    postgresql.org/message-id/90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: daniel@yesql.se, pgsql-bugs@lists.postgresql.org, tomas.vondra@2ndquadrant.com
  Subject: Re: BUG #16683: explain plan format xml produces invalid xml
  In-Reply-To: <90BD07DF-D050-48CE-958E-4B5E5FFCDA37@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox