From: Tom Lane <tgl@sss.pgh.pa.us>
To: Henry Hinze <henry.hinze@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop
Date: Wed, 30 Sep 2020 17:32:04 -0400
Message-ID: <911656.1601501524@sss.pgh.pa.us> (raw)
In-Reply-To: <CAJs-y__J696sux=7--UFSYxyeZ6aLJbdKdhq_YZjgCuxmHhbgw@mail.gmail.com>
References: <16643-eaadeb2a1a58d28c@postgresql.org>
<718213.1601410160@sss.pgh.pa.us>
<CAJs-y_-6c+OH=3ofq7SsANZ7JOpy-yUW37WmAD6XhFi3_csN=w@mail.gmail.com>
<CAJs-y__J696sux=7--UFSYxyeZ6aLJbdKdhq_YZjgCuxmHhbgw@mail.gmail.com>
Henry Hinze <henry.hinze@gmail.com> writes:
> I've made an important observation!
> Since I had the impression this setup was already working with RC1 of PG
> 13, I re-installed RC1 and did the same test. And it's working fine!
Ugh. So that points the finger at commits 07082b08c/bfb12cd2b,
which are the only nearby change between rc1 and 13.0. A quick
comparison of before-and-after checkouts confirms it.
After some digging around, I realize that that commit actually
resulted in a protocol break. libpqwalreceiver is expecting to
get an additional CommandComplete message after COPY OUT finishes,
per libpqrcv_endstreaming(), and it's no longer getting one.
(I have not read the protocol document to see if this is per spec;
but spec or no, that's what libpqwalreceiver is expecting.)
The question that this raises is how the heck did that get past
our test suites? It seems like the error should have been obvious
to even the most minimal testing.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, henry.hinze@gmail.com, alvherre@2ndquadrant.com
Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop
In-Reply-To: <911656.1601501524@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox