agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Ewan Young <kdbase.hack@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: 1217816127@qq.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19545: Integer truncation of `GinTuple.keylen` causes out-of-bounds read in parallel GIN index build
Date: Thu, 17 Sep 2026 22:07:26 -0400
Message-ID: <954960.1789697246@sss.pgh.pa.us> (raw)
In-Reply-To: <e3298f25-f77b-493f-be27-4c380454262e@eisentraut.org>
References: <19545-0f25b7e47351e8fc@postgresql.org>
<CAON2xHMXYLwkq4UaNbUtmaw1ZKne6OqdyyiACFQUbCj+XRBvQQ@mail.gmail.com>
<d02fd089-b326-417a-ab2c-aea88e459c63@iki.fi>
<CAON2xHPV-7O0MsFuizJv8cbUG7ZJfLCAqzkGYgoxF9WBe1v9Jg@mail.gmail.com>
<d6680315-bc66-48c3-a310-bdad88a86a59@iki.fi>
<CAON2xHN5qGXcn1Z00pQAogf4y5rCQ1K04yvrYAORBa5i+ucLBQ@mail.gmail.com>
<479d6c7e-362c-41d8-a263-8d126ecdfd77@eisentraut.org>
<CAON2xHOv4M3rcLzhRcduSMqqmBgzWpZOR9TsK71_agAPNgi=Tg@mail.gmail.com>
<e3298f25-f77b-493f-be27-4c380454262e@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> I have committed these, thanks.
The ABI-compliance-checking buildfarm animals have all been unhappy
since this went in:
'struct GinTuple' changed:
type size changed from 16 to 24 (in bytes)
1 data member deletion:
'uint16 keylen', at offset 6 (in bytes)
1 data member insertion:
'union {Size keylen; double force_align_d; int64 force_align_i64;} u', at offset 8 (in bytes)
there are data member changes:
'int16 typlen' offset changed from 8 to 16 (in bytes) (by +8 bytes)
'bool typbyval' offset changed from 10 to 18 (in bytes) (by +8 bytes)
'signed char category' offset changed from 11 to 19 (in bytes) (by +8 bytes)
'int nitems' offset changed from 12 to 20 (in bytes) (by +8 bytes)
'char data[]' offset changed from 16 to 24 (in bytes) (by +8 bytes)
Is it really okay to change this struct in v18?
If so, the .abi-compliance-history files need to be updated.
regards, tom lane
view thread (14+ messages) latest in thread
Message-ID: <954960.1789697246@sss.pgh.pa.us>
Permalink: ../954960.1789697246@sss.pgh.pa.us/
Also on: postgresql.org/message-id/954960.1789697246@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, kdbase.hack@gmail.com, hlinnaka@iki.fi, 1217816127@qq.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19545: Integer truncation of `GinTuple.keylen` causes out-of-bounds read in parallel GIN index build
In-Reply-To: <954960.1789697246@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox