pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: andrewbille@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable transaction causes Assert at the transaction end
Date: Fri, 11 Mar 2022 14:53:12 -0500
Message-ID: <982894.1647028392@sss.pgh.pa.us> (raw)
In-Reply-To: <CAD21AoA2sivebwQw9602CBf8URFWGKY0=qE6=2wDkm2YhRKnOw@mail.gmail.com>
References: <17385-9ee529fb091f0ce5@postgresql.org>
	<b22395d2-d432-f211-0bed-1f466df75152@postgrespro.ru>
	<CAD21AoCkwsb_Hz6JYbG0X8Jf_VEMheiib0FXpR2kc3UATVCPNQ@mail.gmail.com>
	<CAFiTN-sYZ0Cuyeygp7z8xfoFPhqTAbtnV+k2W9OHp8s0xus5vw@mail.gmail.com>
	<f97d670d-2b03-9d47-6b64-09e6ed2f4d84@postgrespro.ru>
	<CAFiTN-sCr6mYg8A_BBiRz0N68M9QY3uoBWHhbPgHDM-goLJGwg@mail.gmail.com>
	<6e31c4ef-de9a-960b-1a21-e3b6ff0fa9c2@postgrespro.ru>
	<CAD21AoB8acvjt+52iwffAi7Ary_fyMD70X371hVX1JULrc-meQ@mail.gmail.com>
	<2733419.1644789029@sss.pgh.pa.us>
	<CAD21AoCxz=hU3c+6aB3OMNn+9NpH33WEMwOYmCOwh6EzOktYoA@mail.gmail.com>
	<2778050.1644817168@sss.pgh.pa.us>
	<CAD21AoAVuQ=TCCqA1D=eVqG3G_bKLq2zpNeYVV34Ucu2208Hmg@mail.gmail.com>
	<3054063.1644944122@sss.pgh.pa.us>
	<CAD21AoD5MsR_GR5iipc8TnGa3grzQbPLpwZcSn8Fq2dZbar_6g@mail.gmail.com>
	<515672.1646838707@sss.pgh.pa.us>
	<CAD21AoAEHLAJ3=_zoCicyaPSf9-2PnJBb8HixLwPN-rLA6wzNQ@mail.gmail.com>
	<CAD21AoA2sivebwQw9602CBf8URFWGKY0=qE6=2wDkm2YhRKnOw@mail.gmail.com>

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> I've attached a draft patch for discussion.

Hm, I think that trying to RESET a GUC_NO_RESET variable ought to
actively throw an error.  Silently doing nothing will look like
a bug.

(This does imply that it's not sensible to mark a variable
GUC_NO_RESET without also saying GUC_NO_RESET_ALL.  That
seems fine to me, because I'm not sure what the combination
GUC_NO_RESET & !GUC_NO_RESET_ALL ought to mean.)

			regards, tom lane





view thread (44+ messages)  latest in thread

Message-ID: <982894.1647028392@sss.pgh.pa.us>
Permalink:  ../982894.1647028392@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/982894.1647028392@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, sawada.mshk@gmail.com, d.koval@postgrespro.ru, dilipbalaut@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable transaction causes Assert at the transaction end
  In-Reply-To: <982894.1647028392@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox