pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: exclusion@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
Date: Wed, 27 May 2020 15:58:24 -0400
Message-ID: <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com> (raw)
In-Reply-To: <16466-09cfa4a5a0e72cce@postgresql.org>
References: <16466-09cfa4a5a0e72cce@postgresql.org>

On 5/27/20 2:00 PM, PG Bug reporting form wrote:
> The following bug has been logged on the website:
> 
> Bug reference:      16466
> Logged by:          Alexander Lakhin
> Email address:      exclusion@gmail.com
> PostgreSQL version: 13beta1
> Operating system:   Ubuntu 18.04
> Description:        
> 
> When running under valgrind the following query (based on
> contrib/dblink/sql/dblink.sql):
> CREATE EXTENSION dblink;
> CREATE FUNCTION connection_parameters() RETURNS text LANGUAGE SQL AS $f$
>        SELECT $$dbname='$$||current_database()||$$'
> port=$$||current_setting('port');
> $f$;
> SELECT dblink_connect('myconn',connection_parameters());
> SELECT dblink_exec('myconn','BEGIN');
> SELECT dblink_open('myconn','xxx','SELECT 1');
> 
> The following error is detected:
> ==00:00:00:07.723 2378719== Conditional jump or move depends on
> uninitialised value(s)
> ==00:00:00:07.723 2378719==    at 0x486A5D0: dblink_open (dblink.c:492)


Hmmm, looks like a couple of the members of rconn are left uninitialized.

When dblink_open() is called *without* an outer transaction it handles the
initialization for us, but *with* an outer transaction it does not :-(

I think the attached fixes it.

Joe

-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Attachments:

dblink_uninit-vars_20200527.00.diff (text/x-patch, 622B) download diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 2fe5da2..7364332 100644 *** a/contrib/dblink/dblink.c --- b/contrib/dblink/dblink.c *************** dblink_connect(PG_FUNCTION_ARGS) *** 298,305 **** --- 298,310 ---- conname_or_str = text_to_cstring(PG_GETARG_TEXT_PP(0)); if (connname) + { rconn = (remoteConn *) MemoryContextAlloc(TopMemoryContext, sizeof(remoteConn)); + rconn->conn = NULL; + rconn->openCursorCount = 0; + rconn->newXactForCursor = false; + } /* first check for valid foreign data server */ connstr = get_connect_string(conname_or_str);
signature.asc (application/pgp-signature, 832B) download

view thread (4+ messages)  latest in thread

Message-ID: <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com>
Permalink:  ../9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com/
Also on:    postgresql.org/message-id/9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: mail@joeconway.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
  In-Reply-To: <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox