From: Joe Conway <mail@joeconway.com>
To: Alexander Lakhin <exclusion@gmail.com>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
Date: Thu, 28 May 2020 13:50:15 -0400
Message-ID: <3e6699ba-3896-a641-0c95-b64069d77a73@joeconway.com> (raw)
In-Reply-To: <fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com>
References: <16466-09cfa4a5a0e72cce@postgresql.org>
<9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com>
<fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com>
On 5/27/20 5:00 PM, Alexander Lakhin wrote:
> Hello Joe,
>
> 27.05.2020 22:58, Joe Conway wrote:
>> Hmmm, looks like a couple of the members of rconn are left uninitialized.
>>
>> When dblink_open() is called *without* an outer transaction it handles the
>> initialization for us, but *with* an outer transaction it does not :-(
>>
>> I think the attached fixes it.
> Yes, your patch makes valgrind silent.
> Thanks!
Thanks for checking! Pushed to all supported branches.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: mail@joeconway.com, exclusion@gmail.com
Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction
In-Reply-To: <3e6699ba-3896-a641-0c95-b64069d77a73@joeconway.com>
References: <16466-09cfa4a5a0e72cce@postgresql.org> <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com> <fb147109-0512-8dc7-5e29-7b4b89ed246e@gmail.com> <3e6699ba-3896-a641-0c95-b64069d77a73@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox