pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: psuderevsky@gmail.com, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.
Date: Fri, 8 May 2020 14:23:32 +0900
Message-ID: <9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com> (raw)
In-Reply-To: <CAA4eK1LC_6+2Rufgen8UrjWcr1QKgaqyk3atfBHEG=0ZWw2mwQ@mail.gmail.com>
References: <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com>
	<762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net>
	<3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com>
	<20200407.164801.1830442317313243264.horikyota.ntt@gmail.com>
	<4a461c7b-b90a-6644-64a6-80eac69c27bc@pgmasters.net>
	<21d2590f-2739-9f45-748f-7a68d667d7cd@oss.nttdata.com>
	<af0c5065-7807-c06d-29eb-e5b4121327ee@oss.nttdata.com>
	<CAA4eK1JQaL8Kk+E4DqSrYqrNLYusNk22ZLY38JkmCeVdUjotpw@mail.gmail.com>
	<a8baf027-808b-3fdd-7922-0a6c4815d9a6@oss.nttdata.com>
	<CAA4eK1LC_6+2Rufgen8UrjWcr1QKgaqyk3atfBHEG=0ZWw2mwQ@mail.gmail.com>



On 2020/05/07 17:57, Amit Kapila wrote:
> On Thu, May 7, 2020 at 12:13 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/05/02 20:40, Amit Kapila wrote:
>>>
>>> I don't see any obvious problem with the changed code but we normally
>>> don't backpatch performance improvements.  I can see that the code
>>> change here appears to be straight forward so it might be fine to
>>> backpatch this.  Have we seen similar reports earlier as well?  AFAIK,
>>> this functionality is for a long time and if people were facing this
>>> on a regular basis then we would have seen such reports multiple
>>> times.  I mean to say if the chances of this hitting are less then we
>>> can even choose not to backpatch this.
>>
>> I found the following two reports. ISTM there are not so many reports...
>> https://www.postgresql.org/message-id/16159-f5a34a3a04dc67e0@postgresql.org
>> https://www.postgresql.org/message-id/dd6690b0-ec03-6b3c-6fac-c963f91f87a7%40postgrespro.ru
>>
> 
> The first seems to be the same where this bug has been fixed.  It has
> been moved to hackers in email [1].

Yes, that's the original report that leaded to the commit.

>  Am, I missing something?
> Considering it has been encountered by two different people, I think
> it would not be a bad idea to back-patch this.

+1 So I will do the back-patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (6+ messages)  latest in thread

Message-ID: <9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com>
Permalink:  ../9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com/
Also on:    postgresql.org/message-id/9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, amit.kapila16@gmail.com, david@pgmasters.net, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.
  In-Reply-To: <9c76bcab-1804-8c91-b834-5876ae72b9fb@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox