pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org, Stephen Frost <sfrost@snowman.net>
Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords
Date: Mon, 22 Apr 2019 21:26:01 -0400
Message-ID: <9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org> (raw)
In-Reply-To: <20190423010142.GE2712@paquier.xyz>
References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org>
	<4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org>
	<20190422015051.GA3433@paquier.xyz>
	<3033.1555940554@sss.pgh.pa.us>
	<5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org>
	<30284.1555972921@sss.pgh.pa.us>
	<15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org>
	<20190423010142.GE2712@paquier.xyz>

On 4/22/19 9:01 PM, Michael Paquier wrote:

> 
> Also, the extra SELECT query with regexp_replace() is a bit overkill
> for the purpose, and copying again a copy of the regexp around is no
> fun.
> 
> In short, I would simplify things as the attached.  What do you think?

Outside of the strlen comments, I do like the changes to the tests, +1

I did purposely keep the SCRAM + MD5 changes as separate patches as I
felt they were both atomic, but I have no strong opinions on that.

Thanks,

Jonathan

Attachments:

  [application/pgp-signature] signature.asc (832B, ../9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org/2-signature.asc)
  download

view thread (27+ messages)  latest in thread

Message-ID: <9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org>
Permalink:  ../9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org/
Also on:    postgresql.org/message-id/9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: jkatz@postgresql.org, michael@paquier.xyz, tgl@sss.pgh.pa.us, sfrost@snowman.net
  Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords
  In-Reply-To: <9ce16763-836c-041e-06aa-af3e955444cd@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox