pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Zhilin <m.zhilin@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Akshat Jaimini <destrex271@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences
Date: Wed, 03 Apr 2024 08:08:26 +0300
Message-ID: <BD52D958-A09F-40AD-A496-60D997C70BFB@postgrespro.ru> (raw)
In-Reply-To: <1731082.1712084694@sss.pgh.pa.us>
References: <c43ce028-2bc2-4865-9b89-3f706246eed5@postgrespro.ru>
	<2B25F88E-E6AA-4883-B21B-936F7B5D5F78@yandex-team.ru>
	<171170826140.2046436.12738244831107414180.pgcf@coridan.postgresql.org>
	<1731082.1712084694@sss.pgh.pa.us>

Thanks to all for review, testing and commit!!! 


On 2 April 2024 22:04:54 GMT+03:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Akshat Jaimini <destrex271@gmail.com> writes:
>> The code seems to implement the feature and has good and explanatory comments associated with it.
>> I believe we can go ahead with committing patch although I would request some senior contributors to also take a look at this patch since I am relatively new to patch reviews.
>
>Looks like a good catch and a reasonable fix.  Pushed after rewriting
>the comments a bit.
>
>As far as this goes:
>
>> I ran make installcheck-world after applying the patch and recompiling it. It did fail for a particular test but from the logs it seems to be unrelated to this particular patch since it fails for the following:
>
>> ==========================
>> select error_trap_test();
>> -      error_trap_test      
>> ----------------------------
>> - division_by_zero detected
>> -(1 row)
>> -
>> +ERROR:  cannot start subtransactions during a parallel operation
>
>... that's the test case from 0075d7894, and the failure is what
>I'd expect from a backend older than that.  Maybe you forgot to
>recompile/reinstall after updating past that commit?
>
>			regards, tom lane

view thread (7+ messages)  latest in thread

Message-ID: <BD52D958-A09F-40AD-A496-60D997C70BFB@postgrespro.ru>
Permalink:  ../BD52D958-A09F-40AD-A496-60D997C70BFB@postgrespro.ru/
Also on:    postgresql.org/message-id/BD52D958-A09F-40AD-A496-60D997C70BFB@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: m.zhilin@postgrespro.ru, tgl@sss.pgh.pa.us, destrex271@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences
  In-Reply-To: <BD52D958-A09F-40AD-A496-60D997C70BFB@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox