From: Richard Guo <guofenglinux@gmail.com>
To: 甄明洋 <zhenmingyang@yeah.net>
Cc: pgsql-bugs@postgresql.org
Subject: Re: A structure has changed but comment modifications maybe missed
Date: Mon, 27 Mar 2023 10:05:55 +0800
Message-ID: <CAMbWs4817qLtBLNOM51VH=+tbkU42v4VaP_AgvMjurF_vO2-Cw@mail.gmail.com> (raw)
In-Reply-To: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
References: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
On Sat, Mar 25, 2023 at 10:43 PM 甄明洋 <zhenmingyang@yeah.net> wrote:
> Recently when I was reading the TupleTableSlot code, I noticed that the
> field "tts_tuple" mentioned in the comment has been removed in the higher
> version, but it still exists in the comment.
> location：
>
> https://github.com/postgres/postgres/blob/master/src/include/executor/tuptable.h
> src/include/executor/tuptable.h：71
> src/include/executor/tuptable.h：271
>
Good catch. This should be a minor oversight in 4da597ed, in which the
TupleTableSlot implementation has been splitted into different slot
types, and tts_tuple has been removed from TupleTableSlot struct.
Besides, at tuptable.h:71, I think TTS_SHOULDFREE should be
TTS_FLAG_SHOULDFREE.
Thanks
Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: guofenglinux@gmail.com, zhenmingyang@yeah.net
Subject: Re: A structure has changed but comment modifications maybe missed
In-Reply-To: <CAMbWs4817qLtBLNOM51VH=+tbkU42v4VaP_AgvMjurF_vO2-Cw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox