public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bilal Yavuz <[email protected]>
To: VASUKI M <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: BharatDB <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: Tue, 9 Dec 2025 15:47:13 +0300
Message-ID: <CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com> (raw)
In-Reply-To: <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
References: <[email protected]>
<CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
<CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
<[email protected]>
<[email protected]>
<CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
<[email protected]>
<CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
Hi,
On Tue, 9 Dec 2025 at 13:23, VASUKI M <[email protected]> wrote:
>
> Thanks Michael and Peter for the detailed reviews and for taking the time to refine and commit the updated version.
>
> Thanks for pointing out that pgperltidy may behave differently across environments.
>
> On Tue, 9 Dec 2025 at 11:56, Michael Paquier <[email protected]> wrote:
>>
>> The attached takes care of the issue here. Adding that to pgxs_bins
>> may look adapted at first glance, but I don't quite see the point in
>> exposing this information to PGXS, so pgxs_empty is a better fit?
>>
> Thanks for the clarification.Given that PGXS extensions don't appear to require NM ,IMO adding it to pgxs_empty makes sense to me.It resolves the Meson warning without exposing unnecessary variables to PGXS users.
I agree with both of you. We do the same thing for 'ZIC' binary, so I
think putting it to pgxs_empty is the correct fix.
--
Regards,
Nazir Bilal Yavuz
Microsoft
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
In-Reply-To: <CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox