From: Daniel Gustafsson <daniel@yesql.se>
To: Tobias Bussmann <t.bussmann@gmx.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Guertin <markguertin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: Thu, 20 Apr 2023 13:15:40 +0200
Message-ID: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se> (raw)
In-Reply-To: <CDA8E1B5-C146-4954-867A-AF5A4B9E9C43@gmx.net>
References: <E258CE50-AB0E-455D-8AAD-BB4FE8F882FB@gmail.com>
<794684A8-D3FF-4109-815F-C9EB66AF65EA@gmx.net>
<3000521.1681928151@sss.pgh.pa.us>
<ZECELdGIt2xGSWte@paquier.xyz>
<5781DAEE-66E2-41F5-BE03-E82C729F1340@yesql.se>
<CDA8E1B5-C146-4954-867A-AF5A4B9E9C43@gmx.net>
> On 20 Apr 2023, at 11:51, Tobias Bussmann <t.bussmann@gmx.net> wrote:
>
>> Am 20.04.2023 um 10:50 schrieb Daniel Gustafsson <daniel@yesql.se>:
>>
>> Skimming other callsites of ReadDir and readdir I didn't see any others
>> which could benefit from skipping hidden files.
>
> Could /src/bin/pg_rewind/filemap.c be another candidate for skipping hidden files? The 'copy all other files'-behaviour seems to be similar to what pg_basebackup does and it uses the same exclude_list_item blacklist mechanism.
Maybe. I'm a bit hesitant to add too many smarts to pg_rewind. It's a tool
for when something has gone wrong with a cluster (albeit probably not at the
filesystem level), and at that point I feel it's better to put the user fully
in charge. Perhaps I'm overly cautious, curious to hear from others.
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: daniel@yesql.se, t.bussmann@gmx.net, michael@paquier.xyz, tgl@sss.pgh.pa.us, markguertin@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
In-Reply-To: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox