pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tobias Bussmann <t.bussmann@gmx.net>
Cc: Mark Guertin <markguertin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: Thu, 20 Apr 2023 09:15:41 +0900
Message-ID: <ZECELdGIt2xGSWte@paquier.xyz> (raw)
In-Reply-To: <3000521.1681928151@sss.pgh.pa.us>
References: <E258CE50-AB0E-455D-8AAD-BB4FE8F882FB@gmail.com>
	<794684A8-D3FF-4109-815F-C9EB66AF65EA@gmx.net>
	<3000521.1681928151@sss.pgh.pa.us>

On Wed, Apr 19, 2023 at 02:15:51PM -0400, Tom Lane wrote:
> Yeah.  I wonder if we ought to do something more general, and
> ignore all files whose names start with ".".

Indeed.  I don't see any point is adding hidden files for the
checksum, rewind and base backup lists, so we could just make it a
hardcoded rule.  That's currently what we do for configuration files
when using include_dir for postgresql.conf (as well as hba and ident
files in 16~).
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../ZECELdGIt2xGSWte@paquier.xyz/2-signature.asc)
  download

view thread (34+ messages)  latest in thread

Message-ID: <ZECELdGIt2xGSWte@paquier.xyz>
Permalink:  ../ZECELdGIt2xGSWte@paquier.xyz/
Also on:    postgresql.org/message-id/ZECELdGIt2xGSWte@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, t.bussmann@gmx.net, markguertin@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
  In-Reply-To: <ZECELdGIt2xGSWte@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox