From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Date: Thu, 03 Feb 2022 07:55:36 -0800
Message-ID: <DECBA99E-0085-4BCF-8640-3576E0BE4292@anarazel.de> (raw)
In-Reply-To: <E59CF4C1-18F4-4077-9421-99ECA799A8A6@yesql.se>
References: <17391-304f81bcf724b58b@postgresql.org>
<20220202213900.h7paogmcge2rtls6@alap3.anarazel.de>
<CA+hUKGJ4+Ug16QU-PYGEZwUe2O69hdnCuyzLhMHHF02_uA4C5w@mail.gmail.com>
<131329.1643851912@sss.pgh.pa.us>
<203742.1643866877@sss.pgh.pa.us>
<C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
<E59CF4C1-18F4-4077-9421-99ECA799A8A6@yesql.se>
Hi,
On February 3, 2022 7:48:40 AM PST, Daniel Gustafsson <daniel@yesql.se> wrote:
>Pouring over SSL test logs I was again red-herringed by the warning we get for
>using hex() on a large input value, before I remembered that it's benign and
>emerged from the rabbithole:
>
> Hexadecimal number > 0xffffffff non-portable at t/001_ssltests.pl line 508.
>
>We could suppress it by turning off warnings for that line, since we know it
>will work due to the 64-bit int test a few lines before:
>
>@@ -505,6 +505,7 @@ if ($? == 0)
> {
> $serialno =~ s/^serial=//;
> $serialno =~ s/\s+//g;
>+ local $SIG{'__WARN__'} = sub { };
> $serialno = hex($serialno);
> }
> else
>
>Turning of warnings might be a bridge too far for some though? Thoughts?
Can't we just chop serialno into two 32bit numbers and call hex separately? Seems about as hard as adding a comment explaining what the warn bit is about...
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: andres@anarazel.de, daniel@yesql.se, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, pgsql-bugs@lists.postgresql.org, heikki.linnakangas@iki.fi, michael@paquier.xyz
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
In-Reply-To: <DECBA99E-0085-4BCF-8640-3576E0BE4292@anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox