pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Japin Li <japinli@hotmail.com>
To: Önder Kalacı <onderkalaci@gmail.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
Date: Thu, 16 May 2024 17:56:46 +0800
Message-ID: <ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CACawEhX0LrB4sn3-VvyGkEc8Z1UpKw8VsdoAArEvQoL4TJw2Vw@mail.gmail.com>
References: <18467-7bb89084ff03a08d@postgresql.org>
	<CAPmGK14xBjYMoPk6hUy1jyC=gytPB6CJ=CZnaKu=5bWW+beN5Q@mail.gmail.com>
	<ME3P282MB3166635B2A6895BAB182449FB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
	<CACawEhX0LrB4sn3-VvyGkEc8Z1UpKw8VsdoAArEvQoL4TJw2Vw@mail.gmail.com>


On Thu, 16 May 2024 at 17:02, Önder Kalacı <onderkalaci@gmail.com> wrote:
> Hi Japin,
>
>>
>>
>> Here is a poc patch to verify the above.
>>
>>
> The patch looks reasonable to me, it is in line with `get_select_query_def()
> <https://github.com/postgres/postgres/blob/8aee330af55d8a759b2b73f5a771d9d34a7b887f/src/backend/utils...;`
> .
>
> Though, probably requires a regression test.
>

Yeah, add the regression test in v2 patch [1].

[1] https://www.postgresql.org/message-id/ME3P282MB31666446BF8A0C0F7A02D24CB6ED2%40ME3P282MB3166.AUSP282...

--
Regards,
Japin Li





view thread (28+ messages)  latest in thread

Message-ID: <ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
Permalink:  ../ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM/
Also on:    postgresql.org/message-id/ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: japinli@hotmail.com, onderkalaci@gmail.com, etsuro.fujita@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
  In-Reply-To: <ME3P282MB3166168DCC7A5E51277AB34AB6ED2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox