pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: robionekenobi@bluewin.ch, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
Date: Wed, 20 Jan 2021 16:24:47 +0900
Message-ID: <YAfav21sjbWJORCy@paquier.xyz> (raw)
In-Reply-To: <CAC+AXB0gdROT7Gd270wbFkC2uOUOPKFTWv=oZn=3WH_4k37xPw@mail.gmail.com>
References: <16825-c4f104bcebc67034@postgresql.org>
	<CAC+AXB1hEoM+=c6OnNfeDNZzvKtQBuo4qo7W9AkUBNVYEjAqYg@mail.gmail.com>
	<000001d6ecfd$a5fde810$f1f9b830$@bluewin.ch>
	<CAC+AXB2u77E6jvhZmA0J5-6f=Lb9PyhrahNCt-POQ94aD4odLA@mail.gmail.com>
	<YAZs4aHEg+VVL0pP@paquier.xyz>
	<CAC+AXB0gdROT7Gd270wbFkC2uOUOPKFTWv=oZn=3WH_4k37xPw@mail.gmail.com>

On Tue, Jan 19, 2021 at 09:31:22AM +0100, Juan José Santamaría Flecha wrote:
> The scripts assume that the 'msvc' folder is three levels deep,
> 'src/tools/msvc'. If you respect that, you can build with the 'cl /help'
> patch. Please find attached the patch for so.

So, I have been playing with subst and some virtual drives, and this
allows to run builds if for example pointing to the top of a git repo,
which is fancy.

Requiring at least three repository levels is something that we are
going to need anyway as a build requires a full access to the tree,
but I really see no reason to help users with such configurations as
that's basically free for us to do so.  I can see the difference of
output between cl /? and /help for virtual drives, and that's really
surprising, but I see no reason to not apply this patch as this breaks
nothing and /help is an official option.

If there are no objections, I am planning to apply this patch to
HEAD.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (11+ messages)  latest in thread

Message-ID: <YAfav21sjbWJORCy@paquier.xyz>
Permalink:  ../YAfav21sjbWJORCy@paquier.xyz/
Also on:    postgresql.org/message-id/YAfav21sjbWJORCy@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, juanjo.santamaria@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
  In-Reply-To: <YAfav21sjbWJORCy@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox