pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: duspensky@ya.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server with SSL encryption
Date: Wed, 17 Mar 2021 07:22:00 +0900
Message-ID: <YFEviJdl8bDTeutE@paquier.xyz> (raw)
In-Reply-To: <20210316181226.hj6jicxtqveokjyv@alap3.anarazel.de>
References: <16160-18367e56e9a28264@postgresql.org>
	<20191213063915.GE1942@paquier.xyz>
	<20191214092456.GB70616@paquier.xyz>
	<CAGECzQTucR20CLwb6mw_JLdVST8GqYNqYr1OmAnNS2Byg8r+dg@mail.gmail.com>
	<3255514.1615912277@sss.pgh.pa.us>
	<CAGECzQQv-iQ=-EyouczH_s8M6oyT-ga6TwpY+RN9JZH-17bX7w@mail.gmail.com>
	<3345317.1615916184@sss.pgh.pa.us>
	<20210316181226.hj6jicxtqveokjyv@alap3.anarazel.de>

On Tue, Mar 16, 2021 at 11:12:26AM -0700, Andres Freund wrote:
> I wonder if it'd be worth starting to explicitly annotate all the places
> that do allocations and are fine with leaking them. E.g. by introducing
> malloc_permanently() or such. Right now it's hard to use valgrind et al
> to detect leaks because of all the false positives due to such "ok to
> leak" allocations.

Yeah, I have been annoyed by those false positives in the past.  It is
possible to know at quick glance what's wrong once you get used to it,
but anybody running valgrind would be right to be surprised, so having
a different code path for that sounds like a good idea.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (16+ messages)  latest in thread

Message-ID: <YFEviJdl8bDTeutE@paquier.xyz>
Permalink:  ../YFEviJdl8bDTeutE@paquier.xyz/
Also on:    postgresql.org/message-id/YFEviJdl8bDTeutE@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, postgres@jeltef.nl, duspensky@ya.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server with SSL encryption
  In-Reply-To: <YFEviJdl8bDTeutE@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox