pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ярослав Пашинский <yarik97.6@gmail.com>
Cc: Postgres bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16927: Postgres can`t access WAL files
Date: Sat, 20 Mar 2021 09:31:07 +0900
Message-ID: <YFVCSwu4U9htrqJ/@paquier.xyz> (raw)
In-Reply-To: <20210319235645.pznzqhulpjluyco2@alap3.anarazel.de>
References: <CADLmToJJykdGUdKiPkut4mq8oZJ8z4+8d5aSUU9zCtey7yu_9g@mail.gmail.com>
	<YFPMl3TUPXbN127E@paquier.xyz>
	<CADLmTo+GoZ1tuyZxx5uprqSkwqqw3yajry36o-+=N=Jqe=0oZA@mail.gmail.com>
	<YFRglwF+j2RMmbXF@paquier.xyz>
	<CADLmTo+KJoh9+53=7UMfDQALzDEZWXYEUuv3k9YFT4Mo7+0NWQ@mail.gmail.com>
	<YFSMsxc8w2eqUHHR@paquier.xyz>
	<4065519.1616166832@sss.pgh.pa.us>
	<CABUevExwJrT9tAZz0gJKoSc3qLhg3NGsKJH7QWj4BtEK=JHChg@mail.gmail.com>
	<YFUmi3diUlqyoL44@paquier.xyz>
	<20210319235645.pznzqhulpjluyco2@alap3.anarazel.de>

On Fri, Mar 19, 2021 at 04:56:45PM -0700, Andres Freund wrote:
> - I think there needs to be a reference to the problem, otherwise we'll
>   just redo this a couple years down the line
> - I'd not add the XXX, because the whole idea of durable_rename_excl
>   seems wrong to me, and it might motivate people to come up with
>   patches...

Fine by me to remove that :)

What about replacing the XXX comment by a small note, say:
"On Windows, using a hard link followed by an unlink() causes
concurrency issues with code paths interacting with those files, a
rename does not cause that."

If you have a better idea, which I am sure you do, please feel free to
send suggestions.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../YFVCSwu4U9htrqJ%2F@paquier.xyz/2-signature.asc)
  download

view thread (29+ messages)  latest in thread

Message-ID: <YFVCSwu4U9htrqJ/@paquier.xyz>
Permalink:  ../YFVCSwu4U9htrqJ%2F@paquier.xyz/
Also on:    postgresql.org/message-id/YFVCSwu4U9htrqJ/@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de, magnus@hagander.net, tgl@sss.pgh.pa.us, yarik97.6@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16927: Postgres can`t access WAL files
  In-Reply-To: <YFVCSwu4U9htrqJ/@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox