From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: leiyanliang@highgo.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16972: parameter parallel_leader_participation's category problem
Date: Wed, 21 Apr 2021 19:44:58 +0900
Message-ID: <YIACKgzEThp6J81I@paquier.xyz> (raw)
In-Reply-To: <CALj2ACUr--FC3ac7LiZABtX6FaeLqfwbyi+2m629wSPYiZZX5Q@mail.gmail.com>
References: <16972-42d4b0c15aa1d5f5@postgresql.org>
<CALj2ACW_FkQqHb4zvq3WXvKZ2fWkiBKQs6KMr6LMeSi=AY8BvA@mail.gmail.com>
<YH+R+HqLHDyrH1ng@paquier.xyz>
<CALj2ACUr--FC3ac7LiZABtX6FaeLqfwbyi+2m629wSPYiZZX5Q@mail.gmail.com>
On Wed, Apr 21, 2021 at 09:15:23AM +0530, Bharath Rupireddy wrote:
> If we arrange only the "Asynchronous Behaviour" subsection in
> alphabetical order, I think the order may not be maintained in case of
> new GUCs that may get added there. Because all the other subsections
> are unordered and there's no note of maintaining the order as such.
> And, it looks like the relevant GUCs are grouped for better
> readability. For instance, all "parallelism", "io_concurrency", "jit_"
> related GUCs are together. Developers tend to add the new GUCs in
> relevant areas.
That's up to the committers adding them to be careful, but I of course
agree that the context is important. IMV, we can do a slightly better
organization in "Asynchronous Behaviour". First, backend_flush_after
is independent, and could just be first.
parallel_leader_participation can also be moved after
max_parallel_workers without impacting the readability nor impacting
the set of parallel-ish parameters grouped together.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, leiyanliang@highgo.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16972: parameter parallel_leader_participation's category problem
In-Reply-To: <YIACKgzEThp6J81I@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox