From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru
Date: Thu, 11 Nov 2021 17:08:34 +0900
Message-ID: <YYzPgnGBCi75zOWy@paquier.xyz> (raw)
In-Reply-To: <20211111.121909.1128935906296628969.horikyota.ntt@gmail.com>
References: <17280-37da556e86032070@postgresql.org>
<20211111.103923.2138998724021170559.horikyota.ntt@gmail.com>
<YYyFawH87Sv3VZGi@paquier.xyz>
<20211111.121909.1128935906296628969.horikyota.ntt@gmail.com>
On Thu, Nov 11, 2021 at 12:19:09PM +0900, Kyotaro Horiguchi wrote:
> I'm not sure which is easier to read, but it might be a bit hard since
> the conditino term in not mention counter itself. I don't object to
> that way. And, yes SLRU_NUM_ELEMENTS cannot be used here:p
>
> The attached is the first way in the choices.
That looks fine.
Also, what do you think about adding a test in sysviews.sql? This
could be as simple as that:
SELECT count(*) > 0 AS ok FROM pg_stat_slru;
I am not sure if the buildfarm animals running valgrind would have
caught this issue, but having something would be better than nothing
for this case.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../YYzPgnGBCi75zOWy@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru
In-Reply-To: <YYzPgnGBCi75zOWy@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox