pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alexey Ermakov <alexey.ermakov@dataegret.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Maxim Boguk <maxim.boguk@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Subject: Re: BUG #17268: Possible corruption in toast index after reindex index concurrently
Date: Thu, 11 Nov 2021 18:09:49 +0900
Message-ID: <YYzd3dsYi/LiwWuc@paquier.xyz> (raw)
In-Reply-To: <20211109064217.GC940092@rfd.leadboat.com>
References: <20211108183646.r3y6pldylxngxwl4@alap3.anarazel.de>
	<20211108185317.fz42txmnkqdkpix6@alap3.anarazel.de>
	<20211108203641.whpia3pzjofellf4@alap3.anarazel.de>
	<20211109035624.GA940092@rfd.leadboat.com>
	<B706E617-2172-4460-845A-B76E5DB2E0A2@anarazel.de>
	<YYoA24hSkx6EYWpx@paquier.xyz>
	<20211109050848.oe3u6mhtomkaoxrx@alap3.anarazel.de>
	<20211109054625.GB940092@rfd.leadboat.com>
	<20211109063119.ukcvdk7uvz7ks3pa@alap3.anarazel.de>
	<20211109064217.GC940092@rfd.leadboat.com>

On Mon, Nov 08, 2021 at 10:42:17PM -0800, Noah Misch wrote:
> On Mon, Nov 08, 2021 at 10:31:19PM -0800, Andres Freund wrote:
>> On 2021-11-08 21:46:25 -0800, Noah Misch wrote:
>>> Doing both sounds harmless.  Regarding REINDEX CONCURRENTLY on a system
>>> catalog, I bet that can still reach bugs even if we do both, considering this:
>> 
>> Normal catalog aren't REINDEX CONCURRENTLY. It's just toast tables that are
>> kind of system-y, but also kind of not, that can be reindexed concurrently.
> 
> Oh, okay.

To be clear on this point, users cannot reindex concurrently catalog
indexes and toast indexes associated to catalog tables, just toast
indexes of normal tables.  I don't know if any of you have been
working on a patch, but I was cooking something.  It would be worth
checking if an isolation test could be written.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (28+ messages)  latest in thread

Message-ID: <YYzd3dsYi/LiwWuc@paquier.xyz>
Permalink:  ../YYzd3dsYi%2FLiwWuc@paquier.xyz/
Also on:    postgresql.org/message-id/YYzd3dsYi/LiwWuc@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, noah@leadboat.com, andres@anarazel.de, alexey.ermakov@dataegret.com, robertmhaas@gmail.com, maxim.boguk@gmail.com, pgsql-bugs@lists.postgresql.org, pg@bowt.ie
  Subject: Re: BUG #17268: Possible corruption in toast index after reindex index concurrently
  In-Reply-To: <YYzd3dsYi/LiwWuc@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox