From: Michael Paquier <michael@paquier.xyz>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Christoph Berg <christoph.berg@credativ.de>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error
Date: Tue, 7 Jun 2022 11:53:08 +0900
Message-ID: <Yp69lO4sAtP3xUZJ@paquier.xyz> (raw)
In-Reply-To: <CAKFQuwaQvHekKZo6y4ajmRfEjwkPvt_8YDWqVJnfL4py4txFqg@mail.gmail.com>
References: <YphNHbOkg22H7d52@paquier.xyz>
<20220603.175603.682874096867945240.horikyota.ntt@gmail.com>
<Yp1jUAVnyYfn80vu@paquier.xyz>
<20220606.151124.656806001979080471.horikyota.ntt@gmail.com>
<CA+TgmoZnSjX_rFK_EeuCS6TNZkQBwS=2q=BdZSwU4B0BVVwjVw@mail.gmail.com>
<CAKFQuwaQvHekKZo6y4ajmRfEjwkPvt_8YDWqVJnfL4py4txFqg@mail.gmail.com>
On Mon, Jun 06, 2022 at 01:05:46PM -0700, David G. Johnston wrote:
> We've done worse when dealing with obvious bugs contrary to the
> documentation and that prevent unsafe behavior. People relying on the
> defined behavior to safely fail when encountering unexpected failure
> producing situations that hopefully never happen get the priority over
> poorly written code that somehow relies on errors not respecting the single
> transaction promise.
Yeah, I think that the past behavior was a bit crazy. On a
client-side error, psql reports a failure with an error code but would
commit any changes that happened before the command that failed with
the underlying commit created by --single-transaction, while
discarding any future commands.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, david.g.johnston@gmail.com, robertmhaas@gmail.com, horikyota.ntt@gmail.com, christoph.berg@credativ.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error
In-Reply-To: <Yp69lO4sAtP3xUZJ@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox