From: Christoph Berg <christoph.berg@credativ.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: robertmhaas@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: psql --on-error-stop (Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still) commits after client-side error
Date: Wed, 15 Jun 2022 11:13:56 +0200
Message-ID: <Yqmi1IcXs5WofNvD@msg.credativ.de> (raw)
In-Reply-To: <Yql3sc3cvYvLlEHu@paquier.xyz>
References: <2649417.1654875709@sss.pgh.pa.us>
<2656555.1654877531@sss.pgh.pa.us>
<Yqbc8bAdwnP02na4@paquier.xyz>
<20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
<3791929.1655131936@sss.pgh.pa.us>
<Yqfk6QSTJjUQodaD@paquier.xyz>
<Yql3sc3cvYvLlEHu@paquier.xyz>
Re: Michael Paquier
> Well, done. One thing that I find a bit surprising in all that is the
> lack of consistency in the handling of the return code of psql when
> the last switch fails when not using ON_ERROR_STOP.
TBH ON_ERROR_STOP itself feels very brittle to me. Besides the fact
that `psql -vON_ERROR_STOP=1` looks very ugly, it's only one typo away
from breaking silently. `psql -vSTOP_ON_ERROR=1` (or -vON_EROR_STOP=1)
looks good as well, but doesn't work.
There should be a proper command line switch for it like
`psql --on-error-stop` since typoing that errors. (The short options
-eEsSq are already taken, so I'd propose psql -Q.)
Christoph
--
Senior Consultant, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Geoff Richardson, Peter Lilley
Unser Umgang mit personenbezogenen Daten unterliegt folgenden
Bestimmungen: https://www.credativ.de/datenschutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: christoph.berg@credativ.de, michael@paquier.xyz, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, robertmhaas@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: psql --on-error-stop (Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still) commits after client-side error
In-Reply-To: <Yqmi1IcXs5WofNvD@msg.credativ.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox