pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: tharakan@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
Date: Wed, 12 Mar 2025 14:03:04 -0500
Message-ID: <Z9HaaODoGk1-4_SL@nathan> (raw)
In-Reply-To: <CAD21AoBLQUZn-jgh7ssOe5KMxGobdmnC0B_zk4yEEqq3PCT+qQ@mail.gmail.com>
References: <CAD21AoDRmWGyQeAdk007kTMHVdFnvPOBvd2iJYB7AqOReQSXWw@mail.gmail.com>
	<Z8d0kvC6B856KT7z@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z8fywBInu4Q4k13q@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAD21AoBVnenMbN4qccEmCOE9H=_Z1PUaPMBf0HPjK4E9W7z3gw@mail.gmail.com>
	<Z8lYuIFdrtF7Wb9K@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAD21AoCSTvvegzU8_JCuxy0k7ff61pCbJY+6aRneY0in5WbwPQ@mail.gmail.com>
	<Z8qZ8PeWec6XdhxZ@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAD21AoBQ2hr4DSJeLy9xg-87A3QpV_Ga9x_pRY3mupZTjMqOEw@mail.gmail.com>
	<Z8v5m4nOSGhCK6dS@ip-10-97-1-34.eu-west-3.compute.internal>
	<CAD21AoBLQUZn-jgh7ssOe5KMxGobdmnC0B_zk4yEEqq3PCT+qQ@mail.gmail.com>

On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> Pushed.

I'm seeing warnings for the CI build on Windows [0] that appear to be
related to this commit:

	c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value

I suspect we just need to do something like commit fe4ecd0 and return
InvalidXLogRecPtr after the ERROR.

[0] https://api.cirrus-ci.com/v1/task/4876492255002624/logs/build.log

-- 
nathan





view thread (26+ messages)  latest in thread

Message-ID: <Z9HaaODoGk1-4_SL@nathan>
Permalink:  ../Z9HaaODoGk1-4_SL@nathan/
Also on:    postgresql.org/message-id/Z9HaaODoGk1-4_SL@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: nathandbossart@gmail.com, sawada.mshk@gmail.com, bertranddrouvot.pg@gmail.com, tgl@sss.pgh.pa.us, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
  In-Reply-To: <Z9HaaODoGk1-4_SL@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox