From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18000: Access method used by matview can be dropped leaving broken matview
Date: Wed, 28 Jun 2023 08:19:15 +0900
Message-ID: <ZJtuc3bLLGdtk27f@paquier.xyz> (raw)
In-Reply-To: <20230627170348.GA1461334@nathanxps13>
References: <18000-9145c25b1af475ca@postgresql.org>
<ZJlN4DFm4FvVxe6v@paquier.xyz>
<ZJpqh3xoFtlwZS9u@paquier.xyz>
<20230627170348.GA1461334@nathanxps13>
On Tue, Jun 27, 2023 at 10:03:48AM -0700, Nathan Bossart wrote:
> I haven't looked at the patch, but assuming it's not calling
> finish_heap_swap(), it might be okay. But it does seem prudent to check
> that the dependency records are handled correctly.
Double-checking, the patch is able to handle that with an extra
changeDependencyFor() in a code path for relkinds that have no
storage. What the patch does not do it look at pg_depend to see if
the dependency records are stored correctly, and that's something it
had better do.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, nathandbossart@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18000: Access method used by matview can be dropped leaving broken matview
In-Reply-To: <ZJtuc3bLLGdtk27f@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox