From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: martin@schlossarek.me
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18057: unaccent removes intentional spaces
Date: Sun, 20 Aug 2023 08:57:29 +0900
Message-ID: <ZOFW6ZBerH/IBoTC@paquier.xyz> (raw)
In-Reply-To: <2334732.1692462604@sss.pgh.pa.us>
References: <18057-62712cad01bd202c@postgresql.org>
<ZNwRq4nV7CBXAoJN@paquier.xyz>
<ZN8NUpx2f9pB+F/g@paquier.xyz>
<2334732.1692462604@sss.pgh.pa.us>
On Sat, Aug 19, 2023 at 12:30:04PM -0400, Tom Lane wrote:
> Yeah, we could extend the parsing rules that way. It would break
> any rules files that currently use double quote as a plain character,
> but it seems unlikely that there are any. In any case, as long as
> this wasn't back-patched I think such a change would be acceptable.
Okay, thanks. Note that we do use double-quotes as a translated
character in a few cases, but as long as these are only handled as a
single character we could be OK. Or actually, wouldn't it be better
to always force escaping even for double quotes listed as single
characters? Based on what unaccent.rules has, that's not necessary,
but it could simplify the python code generating the file or the C
parsing. For example, the existing '”' would become listed as "\"" in
our unaccent.rules.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, martin@schlossarek.me, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18057: unaccent removes intentional spaces
In-Reply-To: <ZOFW6ZBerH/IBoTC@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox