pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Date: Sun, 3 Sep 2023 08:42:55 +0900
Message-ID: <ZPPIf3Uzp9iFrE6M@paquier.xyz> (raw)
In-Reply-To: <1641161693655508@ske52ucy55r5y36k.iva.yp-c.yandex.net>
References: <ZNrqTmKGnZwz9gPI@paquier.xyz>
	<ZNsXBFsFsKcCbP0q@paquier.xyz>
	<CA+hUKGLhFdd-G1DCk9Ze3KnQ_2jUkxyXvGwV_Ha=DWMrDnGHng@mail.gmail.com>
	<ZNxqFgo243DOar4L@paquier.xyz>
	<ZN65RHuB+qNS/G9Q@paquier.xyz>
	<CA+hUKGL0P6CiKuTuxp_bV3peyE61huwPmLEFqVdCt5waqy3QOA@mail.gmail.com>
	<ZN75xA4v14ImLvhy@paquier.xyz>
	<ZOKil9ifJmmAb6di@paquier.xyz>
	<ZPKQA+HHqLVRFBSs@paquier.xyz>
	<1641161693655508@ske52ucy55r5y36k.iva.yp-c.yandex.net>

On Sat, Sep 02, 2023 at 02:51:48PM +0300, Sergei Kornilov wrote:
> Corresponding tmp_check/log/regress_log_038_end_of_wal show error:
> 
> No such file or directory at /home/melkij/tmp/srcs/postgresql/src/test/recovery/../../../src/test/perl/PostgreSQL/Test/Utils.pm line 725.
> 
> pg_config from scan_header function returns
> /home/melkij/tmp/srcs/postgresql/tmp_install/home/melkij/tmp/pgdev/inst/include
> , then the function tries to concatenate
> server/access/xlog_internal.h, while the required file is in
> postgresql/server/access/xlog_internal.h from this directory.
> 
> If I change the test like this for both scan_header, then it succeeds.
> 
> - my @scan_result = scan_header('server/access/xlog_internal.h',
> + my @scan_result = scan_header('postgresql/server/access/xlog_internal.h',
> 
> Is there something wrong with my setup?

I think that's just a mistake I did, as there should not even be a
need for having to specify "server/" for the header path.  If you
switch scan_header() in Utils.pm to use --includedir-server rather
than --includedir, does it work correctly for you? 
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../ZPPIf3Uzp9iFrE6M@paquier.xyz/2-signature.asc)
  download

view thread (86+ messages)  latest in thread

Message-ID: <ZPPIf3Uzp9iFrE6M@paquier.xyz>
Permalink:  ../ZPPIf3Uzp9iFrE6M@paquier.xyz/
Also on:    postgresql.org/message-id/ZPPIf3Uzp9iFrE6M@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, sk@zsrv.org, noah@leadboat.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, thomas.munro@gmail.com
  Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
  In-Reply-To: <ZPPIf3Uzp9iFrE6M@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox