From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Japin Li <japinli@hotmail.com>
Cc: amutu@amutu.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
Date: Sun, 1 Oct 2023 09:54:22 +0900
Message-ID: <ZRjDPucJiWKDJnkf@paquier.xyz> (raw)
In-Reply-To: <1615012.1696121047@sss.pgh.pa.us>
References: <18134-87126d90cb4dd049@postgresql.org>
<MEYP282MB1669351F137C61C19FA9749BB6C2A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
<ZRizujD8HMMpSXG5@paquier.xyz>
<1615012.1696121047@sss.pgh.pa.us>
On Sat, Sep 30, 2023 at 08:44:07PM -0400, Tom Lane wrote:
> Bigger-picture question: should we back-patch this, or just fix it in
> HEAD? It's wrong, but I'm not sure it's so obviously wrong that there
> could not be somebody depending on the existing behavior.
FWIW, I am not excited about a backpatch, so I would keep this as a
HEAD-only change. Sure, the existing behavior is incorrect, but it
would be more annoying to break somebody's script flow after a minor
release. And that's not critical.
(If you want to fix that yourself, please feel free. I can do that
tomorrow by myself but life keeps me busy today and I don't have any
room to keep an eye on the buildfarm.)
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, japinli@hotmail.com, amutu@amutu.com
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
In-Reply-To: <ZRjDPucJiWKDJnkf@paquier.xyz>
References: <18134-87126d90cb4dd049@postgresql.org> <MEYP282MB1669351F137C61C19FA9749BB6C2A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM> <ZRizujD8HMMpSXG5@paquier.xyz> <1615012.1696121047@sss.pgh.pa.us> <ZRjDPucJiWKDJnkf@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox