pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pete Storer <Pete.Storer@sas.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: FW: Query execution failure
Date: Tue, 10 Oct 2023 16:05:11 -0400
Message-ID: <ZSWud549Aaw1o3l_@momjian.us> (raw)
In-Reply-To: <ZRWEEipzh80uCujz@momjian.us>
References: <BL0PR05MB66282A9070EE621D031C27C7F3CE9@BL0PR05MB6628.namprd05.prod.outlook.com>
	<BL0PR05MB66283C57D72E321591AE4EB1F3CE9@BL0PR05MB6628.namprd05.prod.outlook.com>
	<2957101.1674746628@sss.pgh.pa.us>
	<BL0PR05MB66282D22D96AB745FBBD521FF3CF9@BL0PR05MB6628.namprd05.prod.outlook.com>
	<2961799.1674749201@sss.pgh.pa.us>
	<Y9fjfNpP7HZh1YX9@momjian.us>
	<ZRTQHKRhSLndfB5z@momjian.us>
	<802119.1695863173@sss.pgh.pa.us>
	<ZRTklpZCVC0Hy/jp@momjian.us>
	<ZRWEEipzh80uCujz@momjian.us>

On Thu, Sep 28, 2023 at 09:48:02AM -0400, Bruce Momjian wrote:
> On Wed, Sep 27, 2023 at 10:27:34PM -0400, Bruce Momjian wrote:
> > On Wed, Sep 27, 2023 at 09:06:13PM -0400, Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > The attached patch documents this remote sort order requirement.
> > > 
> > > That seems like quite a random place to insert the documentation.
> > > I doubt that the requirement applies only to upper paths -- FDWs
> > > are allowed to return sorted paths for base relations too,
> > > comparable to indexscan paths.
> > 
> > That is the only section of the docs that mentions sort pushdown.
> > I don't see another reasonable location.
> 
> I now think the fdw docs are the wrong place for this since it is a user
> requirement, not a developer one.  I put it in CREATE SERVER, patch
> attached.

Patch applied back to PG 11.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.





view thread (18+ messages)

Message-ID: <ZSWud549Aaw1o3l_@momjian.us>
Permalink:  ../ZSWud549Aaw1o3l_@momjian.us/
Also on:    postgresql.org/message-id/ZSWud549Aaw1o3l_@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, Pete.Storer@sas.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: FW: Query execution failure
  In-Reply-To: <ZSWud549Aaw1o3l_@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox