From: Michael Paquier <michael@paquier.xyz>
To: Dmitry Koval <d.koval@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18274: Error 'invalid XML content'
Date: Mon, 15 Jan 2024 08:34:05 +0900
Message-ID: <ZaRvbaQ8V9uGxXGD@paquier.xyz> (raw)
In-Reply-To: <0eea123f-388a-41ea-9df3-d4606cf9ed8d@postgrespro.ru>
References: <18274-98d16bc03520665f@postgresql.org>
<1616257.1704651529@sss.pgh.pa.us>
<5588db01-45be-48ff-b158-85f789bc502c@postgrespro.ru>
<1314313.1705259848@sss.pgh.pa.us>
<0eea123f-388a-41ea-9df3-d4606cf9ed8d@postgrespro.ru>
On Sun, Jan 14, 2024 at 11:58:07PM +0300, Dmitry Koval wrote:
>> Is there some downside to XML_PARSE_HUGE?
>
> I didn't see any problems during simple testing of patch with the
> XML_PARSE_HUGE.
> Extended testing will be performed soon.
> Then (I hope) we will send a trial version of PostgreSQL with a patch to
> customers who use XML.
If one looks at the libxml2 like this mirror at [1], it is possible to
see that the flag is only used to lift internal hard limits, for stuff
like XML_MAX_TEXT_LENGTH and XML_MAX_NAME_LENGTH for size control, or
max node depths.
Knowing that we have full control of the memory contexts for the XML
nodes, just enforcing the huge flag does not seem like there's any
downside for us. (Right?)
[1]: https://github.com/GNOME/libxml2
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZaRvbaQ8V9uGxXGD@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, d.koval@postgrespro.ru, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18274: Error 'invalid XML content'
In-Reply-To: <ZaRvbaQ8V9uGxXGD@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox