pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Yongtao Huang <yongtaoh2022@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
Date: Mon, 29 Jan 2024 08:18:21 +0900
Message-ID: <ZbbgvVe_xbi-1U6n@paquier.xyz> (raw)
In-Reply-To: <CAOe1Go1N1XHYMXOq6+0=Awcpngmc9ei+3Jou2Om6o=giW+3pvw@mail.gmail.com>
References: <18310-1eb233c5908189c8@postgresql.org>
	<ZbMeI3EyyDlP-Agv@paquier.xyz>
	<CAHewXN=hBb4=Gr-QHiH95Q8XvLxwTRHLDwR4XmGV5PMU4PgNWQ@mail.gmail.com>
	<ZbMp3H9oVvubWkR5@paquier.xyz>
	<CAHewXNnaT6JM1wDR=ZxTiiRkgR+u_2Jd-AF-NiCCQVRL5ysX+A@mail.gmail.com>
	<CAHewXNk5yeUo2XPaqTYSfbkKhEBfKd4VYa7NHv2MzV-mJ9ULpA@mail.gmail.com>
	<CAOe1Go1N1XHYMXOq6+0=Awcpngmc9ei+3Jou2Om6o=giW+3pvw@mail.gmail.com>

On Sun, Jan 28, 2024 at 01:32:08AM +0800, Yongtao Huang wrote:
> Hi Tender Wang,
> 
> I think your code changes *LGTM*. Thanks for your contribution.

Yes, incorrect indentation is something I have noticed in the previous
patches you have sent to the lists: all the new lines have an
incorrect indentation.  See here, where it is mentioned that the code
base uses 4 column tab spacing with tabs preserved:
https://www.postgresql.org/docs/devel/source-format.html

FWIW, I am OK for simple patches, but this is going to make reviews
harder when it comes to read more complicated patches that touch more
code paths.

> Broadcom Greenplum

Glad to see you're still alive and around.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (20+ messages)  latest in thread

Message-ID: <ZbbgvVe_xbi-1U6n@paquier.xyz>
Permalink:  ../ZbbgvVe_xbi-1U6n@paquier.xyz/
Also on:    postgresql.org/message-id/ZbbgvVe_xbi-1U6n@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, yongtaoh2022@gmail.com, tndrwang@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18310: Some SQL commands fail to process duplicate objects with error: tuple already updated by self
  In-Reply-To: <ZbbgvVe_xbi-1U6n@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox