pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Alexander Lakhin <exclusion@gmail.com>
Cc: jian he <jian.universality@gmail.com>
Subject: Re: BUG #18314: PARALLEL UNSAFE function does not prevent parallel index build
Date: Thu, 7 Mar 2024 08:42:08 +0900
Message-ID: <Zej_UL_LDHA9Amvz@paquier.xyz> (raw)
In-Reply-To: <387720.1709766110@sss.pgh.pa.us>
References: <CACJufxFzy4A8Pbk-TtVa1+cjx9Kf09m+7EOEAYwN0ex4mZEjSA@mail.gmail.com>
	<ZeaVK_J8b29Gxv_P@paquier.xyz>
	<CAHewXNnepBeJ5kBCpF6GFh6yxChXWjNEVMRTP+1KYJCMS+Ks_w@mail.gmail.com>
	<CACJufxEQGsCqsa2XZMQdHtZxwBD8tncLDJV32+6G9y4bOi0jVg@mail.gmail.com>
	<ZeeggQxKb8uBLV35@paquier.xyz>
	<CAHewXN=UaAaNn9ruHDH3Os8kxLVmtWqbssnf=dZN_s9=evHUFA@mail.gmail.com>
	<CAHewXN=D5fm6NtmjXhN0G=KBPt1oft=2pUwJB1-Ddbx0ApxLKQ@mail.gmail.com>
	<162802.1709746091@sss.pgh.pa.us>
	<Zejw-Qasf7b5Lxuq@paquier.xyz>
	<387720.1709766110@sss.pgh.pa.us>

On Wed, Mar 06, 2024 at 06:01:50PM -0500, Tom Lane wrote:
> Sure, but the current patch just trades one set of errors for others.
> As I said, if we care about this problem then the right fix will
> involve serializing/deserializing already-const-folded expression
> trees instead of expecting that the workers can regenerate those.
> I don't personally think it's worth the trouble, especially not if
> we can get rid of the need for exception-using functions to be marked
> parallel unsafe.

I don't know if that's worth tackling either.  It sounds like this is
just something we should do only if someone comes up with a good use
case for it, outside of the subtransaction handling in the workers.

Anyway, I've just reverted the change for now.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (21+ messages)

Message-ID: <Zej_UL_LDHA9Amvz@paquier.xyz>
Permalink:  ../Zej_UL_LDHA9Amvz@paquier.xyz/
Also on:    postgresql.org/message-id/Zej_UL_LDHA9Amvz@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, tndrwang@gmail.com, exclusion@gmail.com, jian.universality@gmail.com
  Subject: Re: BUG #18314: PARALLEL UNSAFE function does not prevent parallel index build
  In-Reply-To: <Zej_UL_LDHA9Amvz@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox