From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: a.kozhemyakin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18483: Segmentation fault in tests modules
Date: Mon, 17 Jun 2024 14:29:05 +0900
Message-ID: <Zm_JoQRXNe6nWb7N@paquier.xyz> (raw)
In-Reply-To: <ZmaUKZOmjv-L9EvK@paquier.xyz>
References: <18483-30bfff42de238000@postgresql.org>
<Zl5GS6SHBXRAkl_c@paquier.xyz>
<219049.1717792376@sss.pgh.pa.us>
<ZmOJ3jfeltZQnN_M@paquier.xyz>
<439c9310-1d71-f2c6-b213-a9a2ea732ba9@gmail.com>
<336833.1717859243@sss.pgh.pa.us>
<250a21e5-d677-6b2a-2692-cd4233785e37@gmail.com>
<ZmaUKZOmjv-L9EvK@paquier.xyz>
On Mon, Jun 10, 2024 at 02:50:33PM +0900, Michael Paquier wrote:
> On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote:
>> 4)
>> I guess, make_tuple_indirect() could be improved with:
>> /* only work on existing, not-null varlenas */
>> if (TupleDescAttr(tupdesc, i)->attisdropped ||
>> nulls[i] ||
>> - TupleDescAttr(tupdesc, i)->attlen != -1)
>> + TupleDescAttr(tupdesc, i)->attlen != -1 ||
>> + TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
>
> Fun. True enough that this function is only here for toastable
> values, so that makes sense.
This one was indeed simple enough, so fixed it for now.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, tgl@sss.pgh.pa.us, a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18483: Segmentation fault in tests modules
In-Reply-To: <Zm_JoQRXNe6nWb7N@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox