From: Michael Paquier <michael@paquier.xyz>
To: Tender Wang <tndrwang@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18630: Incorrect memory access inside ReindexIsProcessingIndex() on VACUUM
Date: Fri, 27 Sep 2024 09:45:12 +0900
Message-ID: <ZvYAGAdUEArQsOdA@paquier.xyz> (raw)
In-Reply-To: <CAHewXNkKDAfco=7ti=pphiPb0uRb=GFM2x4Z2St1HkG7J-32RA@mail.gmail.com>
References: <18630-9aed99c38830657d@postgresql.org>
<CAHewXNnNZXbq_sW=OP-O-1nnMEnpXJX6djbzF52LtDA6tOutiQ@mail.gmail.com>
<CAHewXNkKeE3i7aT_nysWphRHhwMnyG1r55Di=RCNtLa5dRSd4Q@mail.gmail.com>
<ZvUG1qsjXqppi2BO@paquier.xyz>
<CAHewXNkKDAfco=7ti=pphiPb0uRb=GFM2x4Z2St1HkG7J-32RA@mail.gmail.com>
On Thu, Sep 26, 2024 at 03:24:25PM +0800, Tender Wang wrote:
> Agree. The attached patch LGTM.
I have fixed this issue and backpatched it all the way down for now.
One thing that we still lack is a set of reliable tests. This can be
achieved with injection points, and that's much broader than only this
thread. I'd like to get the coverage with two types of tests,
roughly:
- Isolation, with waits across the steps of REINDEX CONCURRENTLY, and
some concurrent operation. This thread used one.
- SQL tests, where we could force errors in some code paths to get an
incorrect state. Putting ourselves in a corner where there is an
invalid toast index is just one state. CIC with a UNIQUE index gives
this possibility, but this just works for a "new" index, for early
stages of REINDEX CONCURRENTLY.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tndrwang@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18630: Incorrect memory access inside ReindexIsProcessingIndex() on VACUUM
In-Reply-To: <ZvYAGAdUEArQsOdA@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox