From: Nathan Bossart <nathandbossart@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Christophe Pettus <xof@thebuild.com>
Cc: vaibhave postgres <postgresvaibhave@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Cc: vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Date: Mon, 7 Oct 2024 14:54:18 -0500
Message-ID: <ZwQ8anV_Xn62frq-@nathan> (raw)
In-Reply-To: <20241007194054.5d@rfd.leadboat.com>
References: <5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
<2649165.1726898595@sss.pgh.pa.us>
<CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
<ZvGye19tHrhLCpFl@nathan>
<E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
<ZvIRG6282T33q3Ku@paquier.xyz>
<00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
<ZvNG2H9GzpQ7YrFQ@paquier.xyz>
<ZwQJYcuPPUsF0reU@nathan>
<20241007194054.5d@rfd.leadboat.com>
On Mon, Oct 07, 2024 at 12:40:54PM -0700, Noah Misch wrote:
> On Mon, Oct 07, 2024 at 11:16:33AM -0500, Nathan Bossart wrote:
>> For consistency with the surrounding code, I think we should schema-qualify
>> the operator and add a newline after "WHERE relpersistence != 't'". If
>> folks agree, I can handle committing the attached patch.
>
> Not just code consistency. A code comment requires the schema qualification:
>
> * Since we execute the constructed query with the default search_path
> * (which could be unsafe), everything in this query MUST be fully
> * qualified.
D'oh. I'm listed as the author of the commit that added that comment and
should've remembered it. I'll just go apply the patch now, then.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, noah@leadboat.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com, xof@thebuild.com, postgresvaibhave@gmail.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
In-Reply-To: <ZwQ8anV_Xn62frq-@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox