pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: zoulx1982@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
Date: Mon, 12 Apr 2021 00:09:45 +0900
Message-ID: <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com> (raw)
In-Reply-To: <20210409224241.GA32072@alvherre.pgsql>
References: <20210409224241.GA32072@alvherre.pgsql>



On 2021/04/10 7:42, Alvaro Herrera wrote:
> On 2021-Mar-24, Fujii Masao wrote:
> 
>> diff --git a/src/backend/access/rmgrdesc/committsdesc.c b/src/backend/access/rmgrdesc/committsdesc.c
>> index 7ebd3d35ef..26bad44b96 100644
>> --- a/src/backend/access/rmgrdesc/committsdesc.c
>> +++ b/src/backend/access/rmgrdesc/committsdesc.c
>> @@ -38,31 +38,6 @@ commit_ts_desc(StringInfo buf, XLogReaderState *record)
>>   		appendStringInfo(buf, "pageno %d, oldestXid %u",
>>   						 trunc->pageno, trunc->oldestXid);
>>   	}
>> -	else if (info == COMMIT_TS_SETTS)
> 
> You have not pushed this one, right?  I think we should do it now.

Thanks for the ping! Pushed!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (12+ messages)  latest in thread

Message-ID: <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
Permalink:  ../a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com/
Also on:    postgresql.org/message-id/a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, alvherre@alvh.no-ip.org, zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16931: source code problem about commit_ts
  In-Reply-To: <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox